Simpler provider set handling through reflection #18
+152
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets can be configured by having a :set attribute, or by having proper set objects. Overriding Provider.find should no longer be necessary.
|
@cbeer While I could merge this myself, I'd appreciate any feedback you might have on this pull-request. It's a reasonably large change to the way |
|
looks good to me (although I've never used the ARWrapper, so it's really your call). Does this change require a minor version bump, do you think? |
|
It does add new backwards-compatible behaviour, so assuming we're using semantic versioning it does require a minor version bump. I'd give it a few days to see if something of similar size comes along, after which I think it would be worth bumping to 0.3.0. |
tjdett
added a commit
that referenced
this pull request
Aug 16, 2012
Simpler provider set handling through reflection
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets can be now be configured by having a
:setattribute, or by having proper set models that relate back to the provider model.Overriding
Provider.findshould no longer be necessary, which avoids the possibility of messing up resumption token behaviour.