Support testing on Rails 6.1 and 7.0 #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have CI working on this repo (See #87), but I manually ran tests in Rails 5.2, 6.0. 6.1, and 7.0 -- it passed on all of them with no changes BUT there was a deprecation notice in 7. I went ahead and fixed the deprecation notice (also confirming by manually running tests that still passed on all those versions). This will at least allow manual testing on more recent Rails versions, as well as set the path for testing on recent Rails when we restore CI.
|
@mcritchlow and @orangewolf anyone interested in reviewing? If I don't hear from anyone, I may do a merge myself. |
|
This LGTM! Thanks for doing this @jrochkind |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't have CI working on this repo (See #87), but I manually ran tests in Rails 5.2, 6.0. 6.1, and 7.0 -- it passed on all of them with no changes
BUT there was a deprecation notice in 7. I went ahead and fixed the deprecation notice (also confirming by manually running tests that still passed on all those versions).
This will at least allow manual testing on more recent Rails versions, as well as set the path for testing on recent Rails when we restore CI.