Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean app and fix lint issues #57

Open
AlexandraDaraban opened this issue Oct 7, 2019 · 1 comment
Open

Clean app and fix lint issues #57

AlexandraDaraban opened this issue Oct 7, 2019 · 1 comment
Assignees
@AlexandraDaraban

Comments

@AlexandraDaraban
Copy link
Contributor

Fix lint issues and remove unused resources
@AlexandraDaraban AlexandraDaraban self-assigned this Oct 7, 2019
@eduardb
Copy link
Contributor

eduardb commented Oct 7, 2019

Hello, I would like to work on this issue. I hope to get it done today or latest tomorrow.

eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Dispose login subscription when view model is destroyed
955969d
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Remove unneeded declaration in gradle file
4672f69
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Merge unused SDK version resources
f872d32
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Ignore GoogleAppIndexingWarning
713c6bc
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Set autofill attributes
8841263
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Ignore content descriptions for accessibility-wise un…
5021bf9 
…important icons
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Add accessibility label to polling station number input
334805b
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Avoid overlapping items on login screen
09496c9
@eduardb eduardb mentioned this issue Oct 8, 2019
Merged
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Ignore AllowBackup warning
2a9532f
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Dispose login subscription when view model is destroyed
c66bf2c
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Remove unneeded declaration in gradle file
154806d
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Merge unused SDK version resources
4a8defd
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Ignore GoogleAppIndexingWarning
739a454
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Set autofill attributes
ea6f748
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Ignore content descriptions for accessibility-wise un…
57867ce 
…important icons
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Add accessibility label to polling station number input
2b0379a
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Ignore AllowBackup warning
350d08b
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Remove some unused resources
fedc356
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Extract hardcoded text to resources
d2b0276
eduardb pushed a commit to eduardb/mon-vot-android-kotlin that referenced this issue Oct 8, 2019
code4romania#57 Define a lint baseline
3cff24b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexandraDaraban AlexandraDaraban

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eduardb @AlexandraDaraban