scroll bar disappears when you press the hamburger button on navbar

[kwokwilliam]

Seems to have iffy functionality.

[kwokwilliam]

branch: https://github.com/codeandcognition/koconut/tree/bug51/nav-button

merge to summer2018-master: 2eeb30f

Functionality is still a bit off. There may be some workarounds that are required to make it seamless. It could also be part of the regular page size having a horizontal scroll on it.

see: mui/material-ui#5185 and mui/material-ui#8710

Also, I discovered this in a different project, but moving the menu that comes up is done by these lines of code:

                        anchorOrigin={{
                          vertical: 45, // TODO RENAME THIS CONSTANT
                          horizontal: 'left',
                        }}
                        transformOrigin={{
                          vertical: 'top',
                          horizontal: 'left',
                        }}
                        getContentAnchorEl={null}

45 is the pixel height to move the menu down (currently, it's roughly the height of the button.)

getContentAnchorEl={null} doesn't seem to be documented ANYWHERE except for this one issue, mui/material-ui#7961, just fyi.

[kwokwilliam]

There is a further issue where the bottom horizontal scroll bar persists on windows whereas on a mac it doesn't seem to appear.

This MAY have something to do with the windows chrome scroll bar being solid and non-floating vs mac's floating scroll bar that hides itself.

[kwokwilliam]

I fixed the horizontal scroll bar persisting, it was a matter of changing App's css to have the width be 100% rather than 100vw.

This allowed me to pinpoint that the body element was getting a style of padding-right: 17px when the menu is active. This bug is super weird, and I'm unsure where it's coming from. I searched the files for 17px but it doesn't appear anywhere in MaterialUI elements or our code.

Will continue to look.

[kwokwilliam]

mui/material-ui#6022 possible fix, or we could just not use material ui for this button.