Make Localizable
's default implementation of tableName
public
#32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
We added a default implementation for the new
tableName
property in theLocalizable
protocol but failed to mark itpublic
. So now any one usingLocalizable
has to implementtableName
on every enum, which is unacceptable (breaking change).Purpose
Fix the issue with
Localizable.tableName
Scope
public
Discussion
Resolves #31
📈 Coverage
Code: 100%
Documentation: 100%