Skip to content

Make Localizable's default implementation of tableName public #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

mpospese
Copy link
Contributor

Introduction

We added a default implementation for the new tableName property in the Localizable protocol but failed to mark it public. So now any one using Localizable has to implement tableName on every enum, which is unacceptable (breaking change).

Purpose

Fix the issue with Localizable.tableName

Scope

  • mark computed property as public
  • fix SwiftLint warnings for latest release of SwiftLint

Discussion

Resolves #31

📈 Coverage

Code: 100%

image

Documentation: 100%

image

@mpospese mpospese added the bug Something isn't working label Nov 22, 2022
@mpospese mpospese self-assigned this Nov 22, 2022
@mpospese mpospese force-pushed the issue/31-localizable-tableName branch from 3b0217d to d576872 Compare November 22, 2022 19:21
@mpospese mpospese merged commit e05d96b into main Nov 22, 2022
@mpospese mpospese deleted the issue/31-localizable-tableName branch November 22, 2022 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

Successfully merging this pull request may close these issues.

Localizable.tableName needs a public default implementation
2 participants