Update Dockerfile (and Ruby version) #1874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnclmorais
force-pushed
the
update-dockerfile
branch
from
7213d27
to
f094a5e
Compare
7 tasks
|
Since we’re at it… @matyikriszta, what do you think of our GitHub Actions using the Dockerfile to setup everything and run the tests, kind of like this example? This way, we “fill two needs with one deed”: we continuously test our Docker setup and make sure our tests run. |
@biggianteye pointed out to us that our Docker instructions were no longer up to date, running into a few issues while trying to set the website up using them. This commit updates the Ruby version slightly so that we can use another Docker image as a base. Fixes codebar#1869
I’ve found this message to be useless while tests are running, it clutters the terminal.
These two messages would appear on some tests, on the console. With this commit those messages are still caught but don’t show up on the console anymore (in the middle of RSpec’s dots). The messages were: - You have to provide an email address. Usage: rake member:delete'[email@address.com]' - Checking for expected text of nil is confusing and/or pointless since it will always match. Please specify a string or regexp instead. Technically, the second one is not a message we display on the code, but rather an RSpec warning telling us one of our variables was nil. Adding content to the constructor was the solution.
gnclmorais
force-pushed
the
update-dockerfile
branch
from
f094a5e
to
d19e5af
Compare
|
@gnclmorais I merged in #1877, the priority was to get deployment working again. Could you rebase this PR on |
|
#1882 already deal with this, so I’m closing the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@biggianteye pointed out to us that our Docker instructions were no longer up to date, running into a few issues while trying to set the website up using them. This commit updates the Ruby version slightly so that we can use another Docker image as a base. Fixes #1869