missing class from the tutorial example #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Difference between "We will be styling this page" at https://github.com/codebar/tutorials/blob/master/html/lesson2/tutorial.md#today-we-will-be-focusing-on-fundamental-css-concepts and "Download the files required to begin working through the tutorial from here(mac/linux) or here(windows)" at https://gist.github.com/hundred/7332441/download
html/lesson2/example.html
Outdated
| @@ -45,10 +45,10 @@ <h3>Owls:</h3> | |||
| </div> | |||
| <ul id="links"> | |||
| <li> | |||
| <a href="mailto:social@codebar.io?subject=I love owls :: codebar">Email us</a> | |||
| <a href="mailto:social@codebar.io?subject=I love owls :: Codebar">Email us</a> | |||
There was a problem hiding this comment.
sorry to be pedantic but codebar is always a lowercase c, so this is deliberate :)
There was a problem hiding this comment.
Ah, no worries - there was an uppercase C here:
http://tutorials.codebar.io/html/lesson2/tutorial.html
The text
Download the files required to begin working through the tutorial from here (mac/linux)
Links to a zip file here:
https://gist.github.com/hundred/7332441/download
I didn't know which was correct. 👍
There was a problem hiding this comment.
(I'll update the PR tomorrow.)
html/lesson2/example.html
Outdated
| </li> | ||
| <li> | ||
| <a href="mailto:?subject=I love owls :: codebar">Email a friend</a> | ||
| <a href="mailto:?subject=I love owls :: Codebar">Email a friend</a> |
There was a problem hiding this comment.
Same here, lowercase c
|
This looks good to me! ✨ |
|
Thank you for the PR @stampycode and @koddsson for taking the time to review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Difference between "We will be styling this page"
at https://github.com/codebar/tutorials/blob/master/html/lesson2/tutorial.md#today-we-will-be-focusing-on-fundamental-css-concepts
and "Download the files required to begin working through the tutorial from here(mac/linux) or here(windows)"
at https://gist.github.com/hundred/7332441/download