Simplify flow of (*kubeExecutor).Execute #103
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 8, 2020 16:58
This change implements timeouts on orchestration events, preventing rouge operations from blocking indefinitely. Specifically, it: - Switches the Executor.Execute method to accept a context.Context - Modifies (*kubeExecutor).provision and (*kubeExecutor).monitor to use a context.Context. They now return an error when the context is cancelled before completion. - Adds a TestTimeout field to ControllerOptions. This sets the timeout on the Executor's context. It also performs a handful of clean-up tasks, including: - Using UUIDs to name executors - Making TestKubeExecutorProvision a table-driven test
There were some unnecessary conditionals that made the function unnecessarily longer. This commit removes them.
codeblooded
added
refactor
codeblooded
force-pushed
the
feature/controller-options
branch
3 times, most recently
from
679826d to
31e741a
Compare
|
Will refactor later with errors. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were some unnecessary conditionals that made the function unnecessarily longer. This commit removes them.