Use Reflection instead of a Stacktrace for HttpClient Logger name #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add test for logger naming in TypedHttpClient Use Kotlin Reflection instead of an Exceptions Stacktrace Fix JsonHttpClientTest to assert on JsonHTTPClient name, not test class name
|
Thanks! I used the StackWalker to actually get the name of the container class (usually it is a real client of some sort that does http requests) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys, first of all thanks for sharing Klite!
I stumbled upon a minor potential for improvement in the way the name of a logger is determined in classes derived from TypedHttpClient.
The Kotlin Reflection API can provide you with the name of the instantiated class. You might want to consider the Java StackWalk API in case the change I propose is not providing the name you had in mind for the logger.
Both approaches would avoid constructing a Stacktrace which is typically considered a costly operation on the JVM.