Update Jest to 25.4 #106
Merged
Update Jest to 25.4 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time of writing, CRA uses Jest 24 and React Testing Library. This adds the latest version of Jest for us to use instead of using react-scripts. Update Github workflow to use Jest instead of react-script. Add Babel Runtime and Transform Runtime Plugin to handle async calls in our tests.
lpatmo
approved these changes
Apr 26, 2020
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Jest instead of react-scripts as CRA currently uses Jest 24.x.x. Due to an incompatible version of Jest, we're experiencing errors with React Testing Library. See: testing-library/dom-testing-library#477
Alternatively, instead of using
jest-environment-jsdom-sixteenas our testing environment, we just drop our need to test using React Scripts and use a later version of Jest (we'll be moving to this anyways when we move to Next).This PR also adds Babel Runtime and the Transform-Runtime plugin to handle regenerator errors with our asynchronous calls in our specs.
See:
babel/babel#8829
parcel-bundler/parcel#871