Choose a PromptEntry at random rather than random-ish. #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe CI is failing for some reason unrelated to this change. My suite is green locally. |
| entries.by_date.where(date: dates).last | ||
| end | ||
|
|
||
| def random |
|
Everything passes on my machine as well. Looks great to me! 👍 ⛵ |
r00k
force-pushed
the
bo-choose-prompt-at-random
branch
from
de6be14 to
93fa873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #154, our current system for choosing which entry to include
with the daily prompt penalizes consistent writers.
This commit makes our selection of previous entry truly random.
Fixes #154