Handle javax.servlet.http.HttpServletResponse with tests, fixes #36 #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uuf6429
commented
May 19, 2019
...aku/converters/spring/produces/servletresponse/SpringConverterProducesServletResponseTest.kt
Outdated
Show resolved
Hide resolved
|
Sorry to respond this late. Thank you so much for the PR. We'll have a look at it. |
cc-jhr
reviewed
Jun 2, 2019
|
|
||
| private fun HandlerMethod.hasHttpServletResponseParam() = this.methodParameters | ||
| .any { javaxServletResponseClass !== null && it.parameterType.isAssignableFrom(javaxServletResponseClass) } |
There was a problem hiding this comment.
You get the Class using the full qualified class name here. Why not check the name directly in the any expression using that string like:
private fun HandlerMethod.hasHttpServletResponseParam() = this.methodParameters
.any { it.parameterType.name == "javax.servlet.http.HttpServletResponse" }
It also gets rid of the nullable code.
There was a problem hiding this comment.
Well, HttpServletResponse is an interface, so that code snippet can never be true. Moreover, if it was a class, that snippet wouldn't support child classes.
cc-jhr
requested changes
Jun 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36