Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforcing LF in spring-javaformat prevents windows build #1555

Closed
andreashouben opened this issue Dec 11, 2020 · 2 comments · Fixed by #1556
Closed

Enforcing LF in spring-javaformat prevents windows build #1555

andreashouben opened this issue Dec 11, 2020 · 2 comments · Fixed by #1556
Assignees
Labels

Comments

@andreashouben
Copy link
Contributor

andreashouben commented Dec 11, 2020

Currently, the spring-javaformat settings in src/checkstyle/checkstyle.xml enforces an LF ending.

This causes an error when running the build on Windows where the default line ending is CRLF.

I get that CRLF line endings are unwanted in the project, but usually running git with core.autocrlf=true should solve that problem.

There is a similar bug in the spring-javaformat project where it's recommended to simply remove that setting so that it defaults to LF_CR_CRLF:

spring-io/spring-javaformat#202

I propose removing it, too.

@andreashouben
Copy link
Contributor Author

Seems it was just an issue with my local config.

@ccoltx
Copy link
Contributor

ccoltx commented Feb 4, 2021

Hi Andreas, you closed this issue too soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants