Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove lf property from checkstyle.lf #1556

Merged
merged 2 commits into from
Feb 4, 2021

Conversation

andreashouben
Copy link
Contributor

Fixes #1555

@andreashouben
Copy link
Contributor Author

issue was resolved. see #1555

@ccoltx
Copy link
Contributor

ccoltx commented Feb 4, 2021

Reopening pull-request to fix this issue, based on spring's solution. See: spring-io/spring-javaformat@0b36c1c

@ccoltx ccoltx reopened this Feb 4, 2021
Update checkstyle rules so that the `NewlineAtEndOfFile` check no
longer enforces only LF line separators. The default now accepts
LF, CR or CRLF.
@jonashackt jonashackt merged commit cecd887 into master Feb 4, 2021
@jonashackt jonashackt deleted the bug/1555-remove-lf-property-from-checkstyle branch February 4, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enforcing LF in spring-javaformat prevents windows build
3 participants