Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

waitForEnabled fix for webdriver 6 #2336

Merged
merged 1 commit into from
Apr 17, 2020
Merged

waitForEnabled fix for webdriver 6 #2336

merged 1 commit into from
Apr 17, 2020

Conversation

dsharapkou
Copy link
Contributor

@dsharapkou dsharapkou commented Apr 13, 2020 •
edited
Loading

Motivation/Description of the PR

  • Faced issues with using of waitForEnabled - it used waitUntil with default 3000 ms for timeout
  • Pretty similar fix as this one but for waitForEnabled method of WebDriver

Applicable helpers:

  • WebDriver

Type of change

  • 🐛 Bug fix

Checklist:

  • Local tests are passed (Run npm test)

@pablopaul pablopaul requested a review from kobenguyent April 16, 2020 06:07
@DavertMik DavertMik merged commit 31673d1 into codeceptjs:master Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavertMik DavertMik DavertMik approved these changes

@kobenguyent kobenguyent kobenguyent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dsharapkou @DavertMik @kobenguyent