Custom locator playwright #2389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Georgegriff
commented
May 12, 2020
| }; | ||
| waiter = context.waitForFunction(enabledFn, [locator.value, $XPath.toString()], { timeout: waitTimeout }); | ||
| } | ||
| // playwright combined selectors |
There was a problem hiding this comment.
Simplified the code path by just using waitForSelector, no need for a special xpath case
added 2 commits
May 12, 2020 13:56
Georgegriff
commented
May 12, 2020
|
Playwright won't be fixing on their end, but that's fine we can fix here, I need to tidy up linked pr at bit have some failing tests to figure out |
added 3 commits
May 13, 2020 11:58
…deceptJS into custom_locator_playwright
DavertMik
approved these changes
May 13, 2020
kobenguyent
approved these changes
May 13, 2020
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
.not picked up by xpath heuristic microsoft/playwright#2197Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)