Skip to content

fix: expect helper to have custom error message as optional param #4082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 22, 2023
Merged

fix: expect helper to have custom error message as optional param #4082

merged 2 commits into from
Dec 22, 2023

Conversation

kobenguyent
Copy link
Collaborator

Motivation/Description of the PR

  • fix: expect helper to have custom error message as optional param

Type of change

  • 🐛 Bug fix

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

@kobenguyent kobenguyent added bug typescript Changes for typings or typescript compatibility documentation labels Dec 18, 2023
@kobenguyent kobenguyent merged commit b4b6dd8 into 3.x Dec 22, 2023
@kobenguyent kobenguyent deleted the fix-expect-helper-types branch December 22, 2023 05:36
@kobenguyent kobenguyent mentioned this pull request Jan 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell approved these changes

Assignees
No one assigned
Labels
bug documentation typescript Changes for typings or typescript compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kobenguyent @Arhell