-
Couldn't load subscription status.
- Fork 54
feat(allure): screen diff plugin support #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Raytek
wants to merge
8
commits into
codeceptjs:master
Choose a base branch
from
Raytek:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
3cc7351
adding support to allure screen diff plugin
Raytek 13e8850
lint
Raytek c98ba8a
Merge branch 'master' into master
kobenguyent 90647b1
Merge branch 'master' into master
kobenguyent 045c910
Merge branch 'master' into master
kobenguyent 36992be
Merge branch 'master' into master
kobenguyent 5101f7a
Merge branch 'master' into master
Raytek 5fc2218
Merge branch 'master' into master
Raytek File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -233,9 +233,12 @@ class ResembleHelper extends Helper { | |||||||||||||||||||||||||||||||||||||||||||
| const allure: any = require("codeceptjs").container.plugins("allure"); | ||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||
| if (allure !== undefined && misMatch >= options.tolerance) { | ||||||||||||||||||||||||||||||||||||||||||||
| allure.addAttachment("Base Image", fs.readFileSync(this._getBaseImagePath(baseImage, options)), "image/png"); | ||||||||||||||||||||||||||||||||||||||||||||
| allure.addAttachment("Screenshot Image", fs.readFileSync(this._getActualImagePath(baseImage)), "image/png"); | ||||||||||||||||||||||||||||||||||||||||||||
| allure.addAttachment("Diff Image", fs.readFileSync(this._getDiffImagePath(baseImage)), "image/png"); | ||||||||||||||||||||||||||||||||||||||||||||
| allure.addScreenDiff( | ||||||||||||||||||||||||||||||||||||||||||||
| "Screen Diff", | ||||||||||||||||||||||||||||||||||||||||||||
| fs.readFileSync(this._getBaseImagePath(baseImage, options), { encoding: "base64" }), | ||||||||||||||||||||||||||||||||||||||||||||
| fs.readFileSync(this._getActualImagePath(baseImage), { encoding: "base64" }), | ||||||||||||||||||||||||||||||||||||||||||||
| fs.readFileSync(this._getDiffImagePath(baseImage), { encoding: "base64" }), | ||||||||||||||||||||||||||||||||||||||||||||
| ); | ||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+236
to
+241
|
||||||||||||||||||||||||||||||||||||||||||||
| allure.addScreenDiff( | |
| "Screen Diff", | |
| fs.readFileSync(this._getBaseImagePath(baseImage, options), { encoding: "base64" }), | |
| fs.readFileSync(this._getActualImagePath(baseImage), { encoding: "base64" }), | |
| fs.readFileSync(this._getDiffImagePath(baseImage), { encoding: "base64" }), | |
| ); | |
| allure.addAttachment( | |
| "expected", | |
| fs.readFileSync(this._getBaseImagePath(baseImage, options)), | |
| "image/png" | |
| ); | |
| allure.addAttachment( | |
| "actual", | |
| fs.readFileSync(this._getActualImagePath(baseImage)), | |
| "image/png" | |
| ); | |
| allure.addAttachment( | |
| "diff", | |
| fs.readFileSync(this._getDiffImagePath(baseImage)), | |
| "image/png" | |
| ); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading images as base64 strings increases memory/cpu and bloats attachments by ~33%. Prefer passing Buffers (omit the encoding option) to avoid unnecessary encoding and to keep report size smaller.