Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typescript to client to satisfy node-ts peer dep #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add typescript to client to satisfy node-ts peer dep #71

wants to merge 1 commit into from

Conversation

interfect
Copy link

This fixes #70 by adding a dependency that will pull in typescript, which
node-ts demands as a peer dependency but can't install itself.

The version comes from what node-ts currently requires.

@interfect
Add typescript to client to satisfy node-ts peer dep
5a30283 
This fixes codechecks#70 by adding a dependency that will pull in typescript, which
node-ts demands as a peer dependency but can't install itself.
@OmgImAlexis
Copy link
Contributor

This should be closed, ts-node should only be used for development. There's no reason to include it in the actual deps especially when it looks like ts-node isn't even used here. #85

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing dependency on typescript
2 participants
@interfect @OmgImAlexis