[Penpot] Default postgres user for the database
#13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
changed the title
postgres user for the database
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently configured, a default
postgresadmin user is created in the database.Because this user would require a password on the current version of this chart, Postgres fails to start up.
Because this user is not required/used in any way, I would vote to disable it by default.
As with my previous PR: should I add this field to the Readme? (given that it is sort of internal, I would tend not to, but I would like other people's opinion on this change)
I have bumped the Chart version according to what I think fits.
Please not how this version bump is the same for some of the PRs I am offering, so the actual bump may have to change 😉