Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to update to babel-eslint 8.1.1 #367

Closed
tobycox opened this issue Jan 24, 2018 · 1 comment
Closed

Need to update to babel-eslint 8.1.1 #367

tobycox opened this issue Jan 24, 2018 · 1 comment
Assignees

Comments

@tobycox
Copy link

tobycox commented Jan 24, 2018

Bug Template

Actual Behavior

Currently on channel/eslint-4 we get:

/usr/local/node_modules/eslint/lib/rules/no-unused-vars.js:406
            if (target.type === "VariableDeclarator") {
                      ^

TypeError: Cannot read property 'type' of undefined
    at isForInRef (/usr/local/node_modules/eslint/lib/rules/no-unused-vars.js:406:23)
    at variable.references.some.ref (/usr/local/node_modules/eslint/lib/rules/no-unused-vars.js:443:21)
    at Array.some (native)
    at isUsedVariable (/usr/local/node_modules/eslint/lib/rules/no-unused-vars.js:442:40)
    at collectUnusedVariables (/usr/local/node_modules/eslint/lib/rules/no-unused-vars.js:565:26)
    at Program:exit (/usr/local/node_modules/eslint/lib/rules/no-unused-vars.js:617:36)
    at listeners.(anonymous function).forEach.listener (/usr/local/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach (native)
    at Object.emit (/usr/local/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/usr/local/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/usr/local/node_modules/eslint/lib/util/node-event-generator.js:280:22)

Expected Behavior

Shouldn't have exception.

Steps to reproduce

Use channel/eslint-4
With babel and babel-eslint

Relevant links

This commit bumped eslint to 4.15.0: 0594439

However without updating babel-eslint to 8.1.1 we'll hit this issue: eslint/eslint#9767
Currently babel-eslint has just been left on ^8.0.0

@chrishulton
Copy link
Contributor

Thanks for the investigation, babel-eslint has been updated to the latest version (8.2.1).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants