Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for plugins for eslint-8 channel #600

Open
rcrenshaw opened this issue Apr 26, 2023 · 6 comments
Open

Add support for plugins for eslint-8 channel #600

rcrenshaw opened this issue Apr 26, 2023 · 6 comments

Comments

@rcrenshaw
Copy link

Actual Behavior

It would be helpful to be able to get our GitHub Codeclimate checks to pass. Currently, we are getting errors like this:

Parsing error: Cannot find module 'babel-plugin-macros' Require stack: - /code/babel.config.js

Expected Behavior

Our babel.config.js file uses the following plugins that are not present in the list of Dependencies in the eslint-7 package.json file:

@babel/plugin-macros
@babel/preset-typescript
@babel/plugin-proposal-optional-chaining
@babel/plugin-syntax-dynamic-import
@babel/plugin-transform-destructuring
@babel/plugin-proposal-class-properties
@babel/plugin-proposal-private-methods
@babel/plugin-proposal-private-property-in-object
@babel/plugin-proposal-object-rest-spread
@babel/plugin-transform-regenerator
babel-plugin-dynamic-import-node
@babel/plugin-transform-runtime

@RubyBrewsday
Copy link

Hi @rcrenshaw thanks for reaching out about this, just to confirm do you need this change for eslint-8 or for eslint-7? Happy to make the update to both. But wanna prioritize whichever helps y'all out sooner vs later 😄

@rcrenshaw
Copy link
Author

@RubyBrewsday Sorry, this was meant for 8. Thanks!

@RubyBrewsday
Copy link

@rcrenshaw no worries 😄 will try and get a fix out for you in the next few business days and will let you know once that is working. In the meantime please feel free to reach out if you are hitting any other snags by emailing us at support-quality@codeclimate.com.

@rcrenshaw
Copy link
Author

I see that a pull request was merged. Does that mean the change is in effect currently? I was hoping this would fix the issue we are seeing from the github/codeclimate UI but we are still getting the following error on all our JS files. Thanks!
Parsing error: Cannot find module 'babel-plugin-macros' Require stack: - /usr/local/node_modules/@babel/core/lib/config/files/plugins.js - /usr/local/node_modules/@babel/core/lib/config/files/index.js - /usr/local/node_modules/@babel/core/lib/index.js - /usr/local/node_modules/@babel/eslint-parser/lib/worker/babel-core.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/worker/handle-message.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/client.cjs - /usr/local/node_modules/@babel/eslint-parser/lib/index.cjs - /usr/local/node_modules/@eslint/eslintrc/dist/eslintrc.cjs

@RubyBrewsday
Copy link

@rcrenshaw so we are in the process of deploying the changes and it should rollout sometime by the end of the day. Will be sure to ping you once that's out for everyone. 🤞 that things should clear up for yall in a bit (currently a little under 50% rolled out).

@RubyBrewsday
Copy link

Okie doke @rcrenshaw the change should be live now. Your builds should start working, but if you are still running into issues please let us know and we can look into it a bit more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants