only capitalized fixmes #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 14, 2015 17:38
This change reduces false positives found by the fixme engine, such as `fixme: enabled: true` in a .codeclimate.yml
There's no need to exclude this file now that only all caps trigger findings.
| @@ -11,4 +11,3 @@ exclude_paths: | |||
| - "Dockerfile" | |||
| - "bin/fixme" | |||
| - "tests/**" | |||
| - ".codeclimate.yml" | |||
There was a problem hiding this comment.
Because ee8d1cf
Essentially we don't need it now. But happy to keep if that seems preferable?
There was a problem hiding this comment.
Makes sense. I'm cool with removing it
|
One minor question. LGTM |
ABaldwinHunter
pushed a commit
that referenced
this pull request
Dec 14, 2015
only capitalized fixmes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @codeclimate/review
Note: Some additional tests seem good to add, but might require some refactoring of the code. I started working on that in a separate branch, and think it's better as a separate PR.