Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for rubocop-sorbet 0.5.1 (channel rubococp-0-92) #261

Merged
merged 1 commit into from
Oct 29, 2020

Conversation

britneywright
Copy link

Resolves #232

Add's support for the rubocop-sorbet plugin in channel rubocop-0-92.

I made a test project to run the codeclimate CLI against: https://github.com/britneywright/rubocop-sorbet-test

For local testing:

  • Pull down this PR
    • IMAGE_NAME=codeclimate/codeclimate-rubocop-test make image
  • Pull down the rubocop-sorbet-test project
    • bundle install
    • codeclimate analyze -e rubocop-test --dev

Should see an output similar to the following:

Starting analysis
Running rubocop-test: Done!

== Gemfile (2 issues) ==
1: No Sorbet sigil found in file. Try a `typed: true` to start (you can also use `rubocop -a` to automatically add this). [rubocop-test]
1: Prefer single-quoted strings when you don't need string interpolation or special symbols. [rubocop-test]

== thing.rb (2 issues) ==
1: No Sorbet sigil found in file. Try a `typed: false` to start (you can also use `rubocop -a` to automatically add this). [rubocop-test]
1: No Sorbet sigil found in file. Try a `typed: true` to start (you can also use `rubocop -a` to automatically add this). [rubocop-test]

Analysis complete! Found 4 issues.

@britneywright britneywright merged commit aa7f42c into channel/rubocop-0-92 Oct 29, 2020
@britneywright britneywright deleted the britney/0-92/sorbet-plugin branch October 29, 2020 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants