Add RuboCop Migrations #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
1 similar comment
|
👍 |
|
Hey @magec, This looks good to me. You might want to also adjust the category mapping, otherwise this cop will emit |
|
Thanks for reviewing @dblandin ! Added the category. |
|
Hey @magec, Just wanted to follow-up and let you know that I've released an engine update the includes the new rubocop plugin. Let me know if you run into any issues! Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
We want to start using a new rubocop extension we developed (https://rubygems.org/gems/rubocop-migrations). It is a simple gem that disallows index removal from rails migrations (so you don't accidentally remove an index that is being used).
Given that we use codeclimate, it would be nice to be able to use that there.