Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action env var #402

Closed
wants to merge 3 commits into from
Closed

Add GitHub action env var #402

wants to merge 3 commits into from

Conversation

b4nst
Copy link

@b4nst b4nst commented Aug 20, 2019

Following the doc here, I've added the GITHUB_SHA and GITHUB_REF env vars.

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Bastien Arata seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -42,6 +42,7 @@ func Test_loadGitFromENVOrGit(t *testing.T) {
r.NotZero(g.CommittedAt)
})
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@b4nst could you undo this change ?

Copy link
Contributor

@f-moya f-moya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry took us sooo long to get to this one 🙏🏼 - It looks good, one minor comment.

@f-moya
Copy link
Contributor

f-moya commented Dec 6, 2021

@b4nst I just opened a new pr that uses GITHUB_REF_NAME instead of GITHUB_REF. Thanks for you contribution. #481, will be merging tomorrow.

@f-moya f-moya closed this Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants