Bug/add prefix #506
Open
Bug/add prefix #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Still running into this issue, whats the status of the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My use case is running the cc-test-reporter from the project root whereas my coverage files for the frontend are located in
./frontend/test-coverage/lcov.info. I managed to getformat-coverageto work only by firstcd frontend. Which led me to believe theADD_PREFIXflag isn't really working. At least forlcovfiles, because loading the source file is attempted before any prefix is added. And if adding a prefix is required then this will naturally fail. 🤔 Or maybe I'm missing something...I'm reverting some changes made in this PR: #232
This bug is also mentioned here: #422 (comment)
Possibly but not necessarily related: #487