Fix examples that use simplecov #516
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As I mentioned in codeclimate#495 (comment), `cc-test-reporter format-coverage --input-type=simplecov` needs the test to have run with `CC_TEST_REPORTER_ID` is set, otherwise it parses a coverage file in legacy format that crashes `cc-test-reporter`.
|
|
manicmaniac
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I mentioned in #495 (comment),
cc-test-reporter format-coverage --input-type=simplecovneeds the test to have run withCC_TEST_REPORTER_IDis set, otherwise it parses a coverage file in legacy format that crashescc-test-reporter.I would like @fede-moya to review this one, please.