Allow overwriting symlinks #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When extracting regular files, the file is opened for writing with os.O_TRUNC, making it suitable to extract over an existing file. This allows updating a local copy from an updated archive by extracting over it. If a link is added to the archive though, the second time it's extracted, an error occurs since os.Link and os.Symlink will not overwrite. This removes any file currently in place before attempting to write a link.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When extracting regular files, the file is opened for writing with
os.O_TRUNC, making it suitable to extract over an existing file. This allows updating a local copy from an updated archive by extracting over it. If a link is added to the archive though, the second time it's extracted, an error occurs sinceos.Linkandos.Symlinkwill not overwrite. This removes any file currently in place before attempting to write a link.