not adding -n if empty to do-upload command (#1085)

codecov · Sep 13, 2023 · 845c445 · 845c445
1 parent 0016507
commit 845c445
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 13 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/buildExec.test.ts b/src/buildExec.test.ts
@@ -35,10 +35,7 @@ test('general args', () => {
 
 
 test('upload args using context', () => {
-  const expectedArgs = [
-    '-n',
-    '',
-  ];
+  const expectedArgs = [];
   const {uploadExecArgs, uploadCommand} = buildUploadExec();
   if (context.eventName == 'pull_request') {
     expectedArgs.push('-C', `${context.payload.pull_request.head.sha}`);

diff --git a/src/buildExec.ts b/src/buildExec.ts
@@ -149,10 +149,6 @@ const buildUploadExec = () => {
   const exclude = core.getInput('exclude');
 
   const uploadExecArgs = [];
-  uploadExecArgs.push(
-      '-n',
-      `${name}`,
-  );
   const uploadCommand = 'do-upload';
   const uploadOptions:any = {};
   uploadOptions.env = Object.assign(process.env, {
@@ -172,7 +168,12 @@ const buildUploadExec = () => {
       envVarsArg.push(envVarClean);
     }
   }
-
+  if (name) {
+    uploadExecArgs.push(
+        '-n',
+        `${name}`,
+    );
+  }
   if (token) {
     uploadOptions.env.CODECOV_TOKEN = token;
   }