Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v4: New major version tagged prematurely #1089

Closed
3flex opened this issue Sep 15, 2023 · 6 comments
Closed

v4: New major version tagged prematurely #1089

3flex opened this issue Sep 15, 2023 · 6 comments
Assignees
@thomasrockhu-codecov

Comments

@3flex
Copy link

3flex commented Sep 15, 2023

I realise it's probably too late, but FYI using the v4 tag while the new version is in beta causes tools like Renovate (and maybe dependabot?) to automatically open PRs to update to the new version, e.g. detekt/detekt#6490

While it's in beta this is unexpected. The v4 tag should be deleted, and a v4-beta tag used instead.

From https://docs.github.com/en/actions/creating-actions/about-custom-actions#using-tags-for-release-management:

Major versions can be initially released with a beta tag to indicate their status, for example, v2-beta. The -beta tag can then be removed when ready.
@3flex 3flex mentioned this issue Sep 15, 2023
Closed
1 task
@thomasrockhu-codecov
Copy link
Contributor

Sorry about this @3flex, this has been removed and replaced with v4-beta

@skshetry skshetry mentioned this issue Sep 15, 2023
Merged
@nijel nijel mentioned this issue Sep 15, 2023
Closed
nijel added a commit to WeblateOrg/meta that referenced this issue Sep 15, 2023
@nijel
Fix codecov mess
be26514 
See codecov/codecov-action#1089
This was referenced Sep 15, 2023
Merged
Merged
Merged
This was referenced Sep 15, 2023
Closed
Closed
Merged
Closed
Merged
Closed
Closed
Closed
Merged
Merged
@VictorKoenders VictorKoenders mentioned this issue Sep 15, 2023
Closed
This was referenced Sep 15, 2023
Closed
Closed
Closed
Closed
Closed
TonyRL added a commit to DIYgod/RSSHub that referenced this issue Sep 15, 2023
@TonyRL
revert: "chore(deps): bump codecov/codecov-action from 3 to 4 (#13301)"
8a3d9ad 
This reverts commit c5b9662.
Refs: codecov/codecov-action#1089
@martinfleis martinfleis mentioned this issue Sep 15, 2023
Merged
@jGaboardi jGaboardi mentioned this issue Sep 15, 2023
Merged
@ghiscoding ghiscoding mentioned this issue Sep 15, 2023
Merged
@crazy-max crazy-max mentioned this issue Sep 15, 2023
Merged
NiGhTTraX added a commit to NiGhTTraX/strong-mock that referenced this issue Sep 24, 2023
@NiGhTTraX
Revert "chore(deps): update codecov/codecov-action action to v4"
d442e47 
This reverts commit e8e71d2. See
codecov/codecov-action#1089.
@peakji peakji mentioned this issue Sep 24, 2023
Merged
@remarkablemark remarkablemark mentioned this issue Sep 25, 2023
Closed
@thomasrockhu-codecov thomasrockhu-codecov unpinned this issue Sep 25, 2023
@ssbarnea
Copy link

Was anyone able to make the v4 beta version to succeed uploading? I tried and it keeps failing to validate the token, even if I put put the token inside an environment, configured the pipeline to use that environment and passed it, see https://github.com/ansible/ansible-lint/pull/3764/files

Still, pipelines fail complaining about missing token: https://github.com/ansible/ansible-lint/actions/runs/6313000590/job/17140193383 --- when clearly the token was passed.

[8](https://github.com/ansible/ansible-lint/actions/runs/6313000590/job/17140193383#step:15:49)
Error: Codecov: Failed to properly create commit: The process '/home/runner/work/_actions/codecov/codecov-action/v4.0.0-beta.2/dist/codecov' failed with exit code 1

okuramasafumi added a commit to okuramasafumi/alba that referenced this issue Sep 26, 2023
@okuramasafumi
[CI] Revert codecov-action to v3
e1cacc9 
codecov/codecov-action#1089
@thomasrockhu-codecov thomasrockhu-codecov self-assigned this Sep 28, 2023
@thomasrockhu-codecov
Copy link
Contributor

@ssbarnea I'll handle this in your issue here

oittaa added a commit to oittaa/uuid-php that referenced this issue Sep 30, 2023
@oittaa
codecov v4: New major version tagged prematurely
2003313 
codecov/codecov-action#1089
kevinoid added a commit to kevinoid/nodecat that referenced this issue Oct 1, 2023
@kevinoid
Revert "build(deps): bump codecov/codecov-action from 3 to 4"
7ccfa13 
This reverts commit 7f6eac9.

The tagging of codecov/codecov-action@v4 was premature:
codecov/codecov-action#1089
Wait until v4 is out of beta to upgrade.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid added a commit to kevinoid/openapi-transformer-base that referenced this issue Oct 2, 2023
@kevinoid
Revert "build(deps): bump codecov/codecov-action from 3 to 4"
37ce529 
This reverts commit 85284b2.

The tagging of codecov/codecov-action@v4 was premature:
codecov/codecov-action#1089
Wait until v4 is out of beta to upgrade.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid added a commit to kevinoid/openapi-transformer-pipeline that referenced this issue Oct 2, 2023
@kevinoid
Revert "build(deps): bump codecov/codecov-action from 3 to 4"
a7672b9 
This reverts commit 6f3f074.

The tagging of codecov/codecov-action@v4 was premature:
codecov/codecov-action#1089
Wait until v4 is out of beta to upgrade.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid added a commit to kevinoid/promise-nodeify that referenced this issue Oct 2, 2023
@kevinoid
Revert "build(deps): bump codecov/codecov-action from 3 to 4"
d25d685 
This reverts commit e9761c1.

The tagging of codecov/codecov-action@v4 was premature:
codecov/codecov-action#1089
Wait until v4 is out of beta to upgrade.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid added a commit to kevinoid/swagger-spec-validator that referenced this issue Oct 2, 2023
@kevinoid
Revert "build(deps): bump codecov/codecov-action from 3 to 4"
4661680 
This reverts commit b7a9204.

The tagging of codecov/codecov-action@v4 was premature:
codecov/codecov-action#1089
Wait until v4 is out of beta to upgrade.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
kevinoid added a commit to kevinoid/travis-status that referenced this issue Oct 2, 2023
@kevinoid
Revert "build(deps): bump codecov/codecov-action from 3 to 4"
299835e 
This reverts commit 24ce306.

The tagging of codecov/codecov-action@v4 was premature:
codecov/codecov-action#1089
Wait until v4 is out of beta to upgrade.

Signed-off-by: Kevin Locke <kevin@kevinlocke.name>
AndrewChubatiuk pushed a commit to AndrewChubatiuk/VictoriaMetrics that referenced this issue Oct 3, 2023
@hagen1778
build(deps): revert version change for codecov/codecov-action from 4 …
0505481 
…to 3

codecov/codecov-action#1089
Signed-off-by: hagen1778 <roman@victoriametrics.com>
@codingjoe
Copy link

FYI, some might have already merged the v4 upgrade and will see errors now. Removing releases and tags from GitHub is probably not a good practice. I would suggest returning the v4 tag, but with v3 code and jumping a version number. I know it's annoying for you, but the damage is done, and that likely the best path of mitigation for paying customers.

@ScottGarman ScottGarman mentioned this issue Oct 4, 2023
Merged
@jeromegamez jeromegamez mentioned this issue Oct 5, 2023
Merged
4 tasks
@kitsuyui kitsuyui mentioned this issue Oct 5, 2023
Merged
@levBagryansky levBagryansky mentioned this issue Oct 18, 2023
Merged
@vearutop vearutop mentioned this issue Oct 23, 2023
Merged
7 tasks
@samschott samschott mentioned this issue Nov 21, 2023
Merged
fbricon added a commit to jbangdev/jbang-eclipse that referenced this issue Nov 25, 2023
@fbricon
build: use codecov v4-beta
162ec10 
codecov v4 was reverted, this breaks the builds. See codecov/codecov-action#1089
@andreasnoack andreasnoack mentioned this issue Dec 9, 2023
Merged
@schankam
Copy link

schankam commented Dec 28, 2023 •
edited
Loading

@codingjoe I agree, also the setup doc is not up-to-date on the website and suggest using v4.

Screenshot 2023-12-28 at 16 48 44

njbbaer added a commit to njbbaer/simulacra that referenced this issue Dec 29, 2023
@njbbaer
Revert codecov-action to v3 due to:
2a04902 
codecov/codecov-action#1089
leopedroso45 added a commit to leopedroso45/Stable-Diffusion-ImageGen that referenced this issue Dec 29, 2023
@leopedroso45
https://github.com/codecov/codecov-action/issues/1089
02aae0d
@njbbaer njbbaer mentioned this issue Dec 29, 2023
Open
@cpelley cpelley mentioned this issue Jan 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thomasrockhu-codecov thomasrockhu-codecov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@ssbarnea @3flex @codingjoe @schankam @j-wags @thomasrockhu-codecov