-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passing secrets.CODECOV_TOKEN not recognized #44
Comments
Is it the case that this may fail if the secret is set for the main owner, but not a fork, during a PR from the fork to the main owner (upstream repo)? |
So it seems the reason for this is a lack of support for token-less uploads to codecov for Github Actions. Something that seemingly exists for other CI services, e.g., Travis. If you do not consider this an issue of this repo, which is fair, then please close this issue. I hope codecov will implement a token-free, secure upload mechanism for GH Actions soon. |
Hi @CasperWA, thanks for bringing this up! You're right, secrets are not available for forks of repositories, therefore the token wasn't available when you tried to upload to Codecov from the forked repository. I'll push an update to our readme soon because it's definitely worth clarifying With regards to tokenless uploads, we do plan to support them when GitHub releases an API for Actions around early 2020. |
Codecov has to be skipped because the secret isn't available. codecov.io understands that this is an issue which needs a better resolution: codecov/codecov-action#44
Codecov has to be skipped because the secret isn't available. codecov.io understands that this is an issue which needs a better resolution: codecov/codecov-action#44
Codecov has to be skipped because the secret isn't available. codecov.io understands that this is an issue which needs a better resolution: codecov/codecov-action#44
Codecov has to be skipped because the secret isn't available in pull requests from forks, but we want to run the rest of the workflow. This means that coverage will not be updated until the next pull_request from the main repository... which is not ideal, as we may not realize it was the earlier pull_request which impacted coverage. codecov.io understands that this is an issue which needs a better resolution: codecov/codecov-action#44
Hi @ibrahim0814, Are we positive this issue is actually solved? I first thought it was just a one-day server issue but I'm consistently getting this error on coverage upload for my public repos (latest error being https://github.com/frgfm/Holocron/pull/79/checks?check_run_id=1102442559). I haven't changed my coverage report generation and upload job for months, it just started throwing errors at some point. But maybe I did something wrong? Any input would be appreciated! |
@frgfm please upgrade to the latest version of the |
@thomasrockhu Oh thanks! Reading about the issue earlier in other discussions, switching to the latest version didn't seem to help them. But apparently I should have tried it out, because it works! |
Having set up the secret
CODECOV_TOKEN
and passing it as${{ secrets.CODECOV_TOKEN }}
the upload fails with the message:HTTP 400 Please provide the repository token to upload reports via `-t :repository-token`
This is both for
v1
andv1.0.5
ofcodecov-action
.It seems that the action's environment variable
CODECOV_TOKEN
is not set properly or not recognized?It should be mentioned that this has recently started failing, without changing the actions workflow otherwise, i.e., it used to work, but now throws this error.
The text was updated successfully, but these errors were encountered: