-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.1.2 breaking changes #965
Comments
USA-RedDragon
added a commit
to USA-RedDragon/DMRHub
that referenced
this issue
Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
USA-RedDragon
added a commit
to USA-RedDragon/DMRHub
that referenced
this issue
Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965 This likely won't fully fix the issue, as the context will be from the root of the repo.
USA-RedDragon
added a commit
to USA-RedDragon/DMRHub
that referenced
this issue
Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
USA-RedDragon
added a commit
to USA-RedDragon/DMRHub
that referenced
this issue
Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
USA-RedDragon
added a commit
to USA-RedDragon/DMRHub
that referenced
this issue
Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
USA-RedDragon
added a commit
to USA-RedDragon/DMRHub
that referenced
this issue
Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
USA-RedDragon
added a commit
to USA-RedDragon/DMRHub
that referenced
this issue
Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
@USA-RedDragon this is absolutely my fault, I'll make a PR this week and release a new version |
jonnyandrew
added a commit
to matrix-org/matrix-rich-text-editor
that referenced
this issue
May 5, 2023
jonnyandrew
added a commit
to matrix-org/matrix-rich-text-editor
that referenced
this issue
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I noticed that 3.1.2 broke my CI workflows because the action inputs removed
working-directory
. After having a look, I found undocumented breaking changes in the codebase buried in merge commits. Note the release notes: https://github.com/codecov/codecov-action/releases/tag/v3.1.2If this project isn't following semver, that's alright, but having to dig into the code as a user in order to figure out why my workflows broke isn't a good UX. Please call these out in the future.
What's the alternative to
working-directory
? Is that functionality removed? Is #110 no longer valid?The text was updated successfully, but these errors were encountered: