Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1.2 breaking changes #965

Closed
USA-RedDragon opened this issue Apr 25, 2023 · 1 comment · Fixed by #971
Closed

3.1.2 breaking changes #965

USA-RedDragon opened this issue Apr 25, 2023 · 1 comment · Fixed by #971

Comments

@USA-RedDragon
Copy link

USA-RedDragon commented Apr 25, 2023

I noticed that 3.1.2 broke my CI workflows because the action inputs removed working-directory. After having a look, I found undocumented breaking changes in the codebase buried in merge commits. Note the release notes: https://github.com/codecov/codecov-action/releases/tag/v3.1.2

  1. 40a12dc#diff-1243c5424efaaa19bd8e813c5e6f6da46316e63761421b3e5f5c8ced9a36e6b6L86-L88 - This commit removes several options, none of which are updated in the README, and the commit message would lead people to believe the commit was intended as just a version bump.
  2. Another opportunity arose with commit 030a000 that could have been an indicator that breaking changes occurred and that a semver major version or at least a note in the release notes that the inputs had changed.

If this project isn't following semver, that's alright, but having to dig into the code as a user in order to figure out why my workflows broke isn't a good UX. Please call these out in the future.

What's the alternative to working-directory? Is that functionality removed? Is #110 no longer valid?

USA-RedDragon added a commit to USA-RedDragon/DMRHub that referenced this issue Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
USA-RedDragon added a commit to USA-RedDragon/DMRHub that referenced this issue Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965

This likely won't fully fix the issue, as the context will be from the root of the repo.
USA-RedDragon added a commit to USA-RedDragon/DMRHub that referenced this issue Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
USA-RedDragon added a commit to USA-RedDragon/DMRHub that referenced this issue Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
USA-RedDragon added a commit to USA-RedDragon/DMRHub that referenced this issue Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
USA-RedDragon added a commit to USA-RedDragon/DMRHub that referenced this issue Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
USA-RedDragon added a commit to USA-RedDragon/DMRHub that referenced this issue Apr 26, 2023
They don't follow semver and 3.1.2 removed several options: codecov/codecov-action#965
@thomasrockhu-codecov
Copy link
Contributor

@USA-RedDragon this is absolutely my fault, I'll make a PR this week and release a new version

jonnyandrew added a commit to matrix-org/matrix-rich-text-editor that referenced this issue May 5, 2023
jonnyandrew added a commit to matrix-org/matrix-rich-text-editor that referenced this issue May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants