Implement Passthrough of Bash Uploader Arguments #156
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow users to use arguments that can be used in the bash uploader.
Should resolve #73, resolve #76, resolve #92. May resolve #155 by yours truly by usage of
-P
argumentThis also slightly optimized the truthy check in
fail_ci
.Checks if
name
andflags
inputs are used first before adding it into the bash arguments. This eliminates the empty -n and -F flags. Unsure if they were there on purpose though.As well as minor rewording in the README in the Arguments section.
Couple of things to note: