Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Import version properly as string not object #342

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

thomasrockhu
Copy link
Contributor

Fixes an issue found #330 regarding version coming up as github-actions-[Object object]

@thomasrockhu thomasrockhu requested a review from a team June 9, 2021 01:26
@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #342 (5249706) into master (fbeda37) will increase coverage by 0.69%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #342      +/-   ##
==========================================
+ Coverage   96.50%   97.20%   +0.69%     
==========================================
  Files           4        4              
  Lines         143      143              
  Branches       43       43              
==========================================
+ Hits          138      139       +1     
+ Misses          5        4       -1     
Flag Coverage Δ
demo 87.50% <ø> (ø)
script 98.42% <100.00%> (+0.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/buildExec.ts 98.40% <100.00%> (+0.80%) ⬆️
src/version.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fbeda37...5249706. Read the comment docs.

@thomasrockhu
Copy link
Contributor Author

@thomasrockhu thomasrockhu merged commit 29386c7 into master Jun 9, 2021
@thomasrockhu thomasrockhu deleted the 1.5.2 branch June 9, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants