Trim arguments after splitting them

[mitchell-codecov]

Users sometimes have spaces after comma delimiters in comma-separated arguments (e.g., files or flags). This appears to currently cause issues for those multi-value arguments wherein they are passed along to the uploader along with the spaces. For more information, see honeycombio/terraform-provider-honeycombio#197 (comment).

To fix the aforementioned behavior, this PR adds String.prototype.trim to the chain of processing methods used for comma-delimiting; specifically, this happens in three places:

• codecov-action/src/buildExec.ts

  Lines 93 to 97 in 37c776c

  	if (functionalities) {
  	functionalities.split(',').map((f) => f.trim()).forEach((f) => {
  	execArgs.push('-X', `${f}`);
  	});
  	}

• codecov-action/src/buildExec.ts

  Lines 104 to 108 in 37c776c

  	if (files) {
  	files.split(',').map((f) => f.trim()).forEach((f) => {
  	execArgs.push('-f', `${f}`);
  	});
  	}

• codecov-action/src/buildExec.ts

  Lines 109 to 113 in 37c776c

  	if (flags) {
  	flags.split(',').map((f) => f.trim()).forEach((f) => {
  	execArgs.push('-F', `${f}`);
  	});
  	}

[codecov]

Codecov Report

Merging #791 (f41af91) into master (68d5f6d) will increase coverage by 0.64%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
+ Coverage   95.26%   95.90%   +0.64%     
==========================================
  Files           4        4              
  Lines         169      171       +2     
  Branches       48       49       +1     
==========================================
+ Hits          161      164       +3     
+ Misses          8        7       -1     

Flag	Coverage Δ
demo	80.00% <ø> (ø)
macos-latest	95.90% <100.00%> (+0.64%)	⬆️
script	97.43% <100.00%> (+0.68%)	⬆️
ubuntu-latest	95.90% <100.00%> (+0.64%)	⬆️
version	80.00% <ø> (ø)
windows-latest	95.90% <100.00%> (+0.64%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
src/buildExec.ts	99.18% <100.00%> (+0.84%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68d5f6d...f41af91. Read the comment docs.

[webknjaz]

@drazisil-codecov @mitchell-codecov mind cutting a release?

[webknjaz]

By the way, a similar fix may be necessary at https://github.com/codecov/uploader/blob/dae22df/src/index.ts#L124-L131 too.

[drazisil-codecov]

@thomasrockhu-codecov Can you release here?