Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shared with owners trigger #1002

Merged
merged 5 commits into from
Nov 26, 2024

Conversation

adrian-codecov
Copy link
Contributor

@adrian-codecov adrian-codecov commented Nov 25, 2024

Getting rid of some other triggers! Tested on Staging and triggers were deleted.

Additionally added logic for the yaml trigger that I got rid of to persist the overall logic.

Ticket to run risky migration: https://github.com/codecov/infrastructure-team/issues/513

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link
Contributor

github-actions bot commented Nov 25, 2024

This PR includes changes to shared. Please review them here: codecov/shared@f96b72f...c481846

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Copy link
Contributor

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.05%. Comparing base (6b66f3e) to head (c217ba7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1002   +/-   ##
=======================================
  Coverage   96.04%   96.05%           
=======================================
  Files         828      828           
  Lines       19211    19227   +16     
=======================================
+ Hits        18452    18468   +16     
  Misses        759      759           
Flag Coverage Δ
unit 92.28% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 92.28% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrian-codecov adrian-codecov added this pull request to the merge queue Nov 26, 2024
Merged via the queue into main with commit 83e45ab Nov 26, 2024
18 of 19 checks passed
@adrian-codecov adrian-codecov deleted the 1110-update-shared-owner-trigger branch November 26, 2024 16:52
Copy link

sentry-io bot commented Nov 27, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ GraphQLError: Cannot assign "4211159": "Owner.bot" must be a "Owner" instance. /graphql/{service} View Issue
  • ‼️ ValueError: Cannot assign "4211159": "Owner.bot" must be a "Owner" instance. /graphql/{service} View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants