perf: use new get_file_totals() report method for BranchContents #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-codecov
requested review from
giovanni-guidini,
scott-codecov,
trent-codecov and
joseph-sentry
trent-codecov
approved these changes
Nov 16, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=====================================
Coverage 95.53 95.53
=====================================
Files 719 719
Lines 15958 15958
=====================================
Hits 15245 15245
Misses 713 713
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #252 +/- ##
=======================================
Coverage 95.62% 95.62%
=======================================
Files 605 605
Lines 15551 15551
=======================================
Hits 14871 14871
Misses 680 680
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
scott-codecov
added a commit
that referenced
this pull request
Nov 17, 2023
* main: feat: Emit pubsub event when org token is updated (#241) perf: use new get_file_totals() report method for BranchContents (#252) feat: adjust benefits for team plan (#253) fix: Adjust Team plan pricing (#805) (#243) feat: Add Sentry user to admin panel (#702) (#232) metrics: update shared + add sentry traces to BranchContents GraphQL query path (#251) Use the same sentry version (#247) feat(logging): change access logging format to JSON (#249) Use alpine 3.18 (#245) fix(launchscripts): delete contents of prometheus multiproc dir, not dir itself (#244) Make migration info log less confusing (#221) Fix urllib and opentelemetry-instrumentation dependencies (#213) Updating workflows (#242) fix: Handle Shelter storage paths in upload download handler (#234) feat: Modify billing for Team plan (#637) (#225) fix: Upgrade Django version to fix security vulnerabilities (#239) Update small badge (#238) Send github oauth access token expiry with cookie (#237) fix: Skip login if GitHub OAuth does not return access_token (#236)
trent-codecov
added a commit
that referenced
this pull request
Nov 17, 2023
* metrics: update shared + add sentry traces to BranchContents GraphQL query path (#251) * metrics: add sentry traces to BranchContents GraphQL query path * update shared to use merge commit sha * feat: Add Sentry user to admin panel (#702) (#232) Add Sentry user to Django admin dashboard, can search and update Sentry user by name/email and link to the associated User object. Hides access/refresh token fields. * fix: Adjust Team plan pricing (#805) (#243) * feat: adjust benefits for team plan (#253) * perf: use new get_file_totals() report method for BranchContents (#252) * perf: use new get_file_totals() report method for BranchContents * fix tests; update shared + expose fn on mock * update shared to point at merge commit * feat: Emit pubsub event when org token is updated (#241) Co-authored-by: Trent Schmidt <trent@codecov.io> * fix: Use GitHub integration access token when using GH app (#240) * fix: Fallback to OAuth bot token when installation token fails (#255) * fix: Fallback to OAuth bot token when installation token fails * Rename test * Shared update --------- Co-authored-by: matt-codecov <137832199+matt-codecov@users.noreply.github.com> Co-authored-by: JerrySentry <142266253+JerrySentry@users.noreply.github.com> Co-authored-by: Adrian <adrian@codecov.io> Co-authored-by: scott-codecov <scott@codecov.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codecov/shared#83
https://github.com/codecov/internal-issues/issues/155
sentry traces show
ReportPaths.single_directory()taking a while in theBranchContentsgraphql query handler. it basically returns a flat list of directory/file objects with the names/totals of each. it callsreport.get(path).totalsto get the totals which does more processing than is strictly necessary.codecov/shared#83 adds a new
get_file_totals()method toReport/ReadOnlyReportthat returns the values from theReportFileSummaryLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.