Add Self Hosted License Expiration Date to Config Resolver #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
=======================================
Coverage 95.64% 95.64%
=======================================
Files 608 610 +2
Lines 15687 15710 +23
=======================================
+ Hits 15004 15026 +22
- Misses 683 684 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #283 +/- ##
=====================================
Coverage 95.55 95.55
=====================================
Files 722 724 +2
Lines 16094 16117 +23
=====================================
+ Hits 15378 15400 +22
- Misses 716 717 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
JerrySentry
approved these changes
Dec 4, 2023
|
|
||
|
|
||
| @self_hosted_license_bindable.field("expirationDate") | ||
| def resolve_expiration_date(license: LicenseInformation, info) -> datetime.date: |
…osted-license-investigation
…decov/codecov-api into 849-self-hosted-license-investigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
We want to surface a banner in the client to show self-hosted customers a CTA to renew their license. This PR surfaces that information to the client
Links to relevant tickets
codecov/engineering-team#849
What does this PR do?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.