Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use risky migration helpers from shared instead #286

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

matt-codecov
Copy link
Contributor

codecov/shared#93

codecov/shared#72 added django models in shared and codecov/worker#168 imports them to worker. we need to wire worker up to run migrations when it deploys. codecov/shared#93 moves api's risky migration helpers to shared, this PR deletes api's copy and imports shared's

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-qa
Copy link

codecov-qa bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92a1434) 95.66% compared to head (e61b323) 95.95%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   95.66%   95.95%   +0.29%     
==========================================
  Files         612      611       -1     
  Lines       15820    15719     -101     
==========================================
- Hits        15134    15083      -51     
+ Misses        686      636      -50     
Flag Coverage Δ
unit 95.95% <100.00%> (+0.29%) ⬆️
unit-latest-uploader 95.95% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92a1434) 95.57% compared to head (e1ebb60) 95.54%.

❗ Current head e1ebb60 differs from pull request most recent head e61b323. Consider uploading reports for the commit e61b323 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #286     +/-   ##
=======================================
- Coverage   95.57   95.54   -0.03     
=======================================
  Files        726     721      -5     
  Lines      16228   16064    -164     
=======================================
- Hits       15509   15348    -161     
+ Misses       719     716      -3     
Flag Coverage Δ
unit 95.93% <100.00%> (+0.26%) ⬆️
unit-latest-uploader 95.93% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

Merging #286 (e61b323) into main (92a1434) will increase coverage by 0.29%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #286      +/-   ##
==========================================
+ Coverage   95.66%   95.95%   +0.29%     
==========================================
  Files         612      611       -1     
  Lines       15820    15719     -101     
==========================================
- Hits        15134    15083      -51     
+ Misses        686      636      -50     
Flag Coverage Δ
unit 95.95% <100.00%> (+0.29%) ⬆️
unit-latest-uploader 95.95% <100.00%> (+0.29%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
codecov_auth/migrations/0023_auto_20230214_1129.py 100.00% <100.00%> (ø)
...v_auth/migrations/0034_alter_owner_trial_status.py 100.00% <100.00%> (ø)
...auth/migrations/0035_owner_pretrial_users_count.py 100.00% <100.00%> (ø)
codecov_auth/migrations/0037_owner_uses_invoice.py 100.00% <100.00%> (ø)
...v_auth/migrations/0038_alter_owner_uses_invoice.py 100.00% <100.00%> (ø)
...v_auth/migrations/0039_alter_owner_uses_invoice.py 100.00% <100.00%> (ø)
..._auth/migrations/0043_sync_user_terms_agreement.py 100.00% <100.00%> (ø)
...ations/0045_remove_ownerprofile_terms_agreement.py 100.00% <100.00%> (ø)
..._auth/migrations/0046_dedupe_owner_admin_values.py 100.00% <100.00%> (ø)
core/migrations/0002_auto_20210517_1223.py 100.00% <100.00%> (ø)
... and 16 more

Impacted file tree graph

@matt-codecov matt-codecov merged commit df9ebfd into main Dec 14, 2023
16 checks passed
@matt-codecov matt-codecov deleted the matt/use-shared-risky-migrations branch December 14, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants