-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: use risky migration helpers from shared instead #286
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 95.66% 95.95% +0.29%
==========================================
Files 612 611 -1
Lines 15820 15719 -101
==========================================
- Hits 15134 15083 -51
+ Misses 686 636 -50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #286 +/- ##
=======================================
- Coverage 95.57 95.54 -0.03
=======================================
Files 726 721 -5
Lines 16228 16064 -164
=======================================
- Hits 15509 15348 -161
+ Misses 719 716 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #286 +/- ##
==========================================
+ Coverage 95.66% 95.95% +0.29%
==========================================
Files 612 611 -1
Lines 15820 15719 -101
==========================================
- Hits 15134 15083 -51
+ Misses 686 636 -50
Flags with carried forward coverage won't be shown. Click here to find out more.
|
codecov/shared#93
codecov/shared#72 added django models in shared and codecov/worker#168 imports them to worker. we need to wire worker up to run migrations when it deploys. codecov/shared#93 moves api's risky migration helpers to
shared
, this PR deletes api's copy and imports shared'sLegal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.