-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add component filtering for coverageFile type in GQL #292
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=======================================
+ Coverage 95.55 95.56 +0.01
=======================================
Files 726 726
Lines 16151 16160 +9
=======================================
+ Hits 15433 15442 +9
Misses 718 718
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 95.64% 95.65%
=======================================
Files 612 612
Lines 15743 15752 +9
=======================================
+ Hits 15058 15067 +9
Misses 685 685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
=======================================
Coverage 95.64% 95.65%
=======================================
Files 612 612
Lines 15743 15752 +9
=======================================
+ Hits 15058 15067 +9
Misses 685 685
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Purpose/Motivation
In GraphQL API when we query the
coverageFile
type add an option in the input to filter by list of component names, This will work in conjunction with filtering by list of flags. If no coverage for the given components filters will return 0s for totals similar to if no coverage for the given flags. When filtering by both flags and components the result will be an intersection between flags and components.Links to relevant tickets
codecov/engineering-team#826
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.