Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade pytest-django #298

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Upgrade pytest-django #298

merged 1 commit into from
Dec 8, 2023

Conversation

scott-codecov
Copy link
Contributor

The old version was causing some conflicts with database access. If the database connection was first setup through the pytest fixture then subsequent tests (that used the Django TestCase class) would fail.

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c37b27) 95.55% compared to head (fe98bb7) 95.55%.

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #298   +/-   ##
=====================================
  Coverage   95.55   95.55           
=====================================
  Files        726     726           
  Lines      16151   16151           
=====================================
  Hits       15433   15433           
  Misses       718     718           
Flag Coverage Δ
unit ?
unit-latest-uploader ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented Dec 7, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4c37b27) 95.64% compared to head (fe98bb7) 95.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files         612      612           
  Lines       15743    15743           
=======================================
  Hits        15058    15058           
  Misses        685      685           
Flag Coverage Δ
unit 95.64% <ø> (ø)
unit-latest-uploader 95.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Codecov Report

Merging #298 (fe98bb7) into main (4c37b27) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #298   +/-   ##
=======================================
  Coverage   95.64%   95.64%           
=======================================
  Files         612      612           
  Lines       15743    15743           
=======================================
  Hits        15058    15058           
  Misses        685      685           
Flag Coverage Δ
unit 95.64% <ø> (ø)
unit-latest-uploader 95.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted file tree graph

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are my hero 🥇

@scott-codecov scott-codecov merged commit 572fa30 into main Dec 8, 2023
19 checks passed
@scott-codecov scott-codecov deleted the scott/upgrade-pytest-django branch December 8, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants