"fix": allow branch to be overridden in v4 upload endpoint

[matt-codecov]

closes codecov/engineering-team#889

this should allow a commit's branch to be changed if future uploads come in with a new branch set. this could happen if branch heads were reset (e.g. recovering from pushed a commit to the wrong branch) or if the user just wants to take matters into their own hands

NOTE: project coverage delta is calculated by comparing a head report against a base report. if the PR's actual base isn't in our database we use the next-oldest commit from the same branch. if a commit is moved to another branch, then a PR for which that commit is the "next-oldest" will have to use an even older commit. just an edge case to be aware of

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

[codecov-qa]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cd33523) 95.95% compared to head (9ac5d61) 95.95%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         611      611           
  Lines       15719    15722    +3     
=======================================
+ Hits        15083    15086    +3     
  Misses        636      636           

Flag	Coverage Δ
unit	95.95% <100.00%> (+<0.01%)	⬆️
unit-latest-uploader	95.95% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[codecov-public-qa]

Codecov Report

Merging #305 (9ac5d61) into main (cd33523) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   95.95%   95.95%           
=======================================
  Files         611      611           
  Lines       15719    15722    +3     
=======================================
+ Hits        15083    15086    +3     
  Misses        636      636           

Flag	Coverage Δ
unit	95.95% <100.00%> (+<0.01%)	⬆️
unit-latest-uploader	95.95% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
upload/helpers.py	93.77% <100.00%> (+0.07%)	⬆️

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (df9ebfd) 95.57% compared to head (200af14) 95.56%.

❗ Current head 200af14 differs from pull request most recent head 59c7e43. Consider uploading reports for the commit 59c7e43 to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files

@@           Coverage Diff           @@
##            main    #305     +/-   ##
=======================================
- Coverage   95.57   95.56   -0.01     
=======================================
  Files        726     726             
  Lines      16228   16181     -47     
=======================================
- Hits       15509   15462     -47     
  Misses       719     719             

Flag	Coverage Δ
unit	95.65% <100.00%> (-0.31%)	⬇️
unit-latest-uploader	95.65% <100.00%> (-0.31%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.