-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: filter deleted/private repos out of results to graphql queries #307
Conversation
9b3167d
to
4496119
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=====================================
Coverage 95.63 95.63
=====================================
Files 730 730
Lines 16454 16432 -22
=====================================
- Hits 15735 15714 -21
+ Misses 719 718 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 615 615
Lines 15943 15921 -22
=======================================
- Hits 15307 15286 -21
+ Misses 636 635 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #307 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 615 615
Lines 15943 15944 +1
=======================================
+ Hits 15307 15308 +1
Misses 636 636
Flags with carried forward coverage won't be shown. Click here to find out more.
|
closes https://github.com/codecov/internal-issues/issues/131
old logic amounted to:
the private/deleted check is ignored if either of the owner-related predicates are true. that's fine for the private condition, but we want to apply the deleted condition unconditionally. new logic:
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.