-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: stop returning 400 code when user installs github app #314
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #314 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 612 612
Lines 15794 15798 +4
=======================================
+ Hits 15160 15164 +4
Misses 634 634
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #314 +/- ##
=======================================
Coverage 95.98% 95.98%
=======================================
Files 612 612
Lines 15794 15798 +4
=======================================
+ Hits 15160 15164 +4
Misses 634 634
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Purpose/Motivation
Sometimes when a user tries to install the github app (on self-hosted), they will encounter a 400 response
Links to relevant tickets
Fixes: codecov/engineering-team#806
What does this PR do?
get_redirection_url_from_state
to tuple