Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow self hosted admins to have parity with cloud admins for main #316

Merged
merged 6 commits into from
Dec 28, 2023

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented Dec 20, 2023

Purpose/Motivation

Allow self hosted instance admins to erase repo coverage and delete repo flags

Links to relevant tickets

codecov/feedback#181

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

codecov-staging bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d0aaae) 96.00% compared to head (527546c) 96.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         614      614           
  Lines       15897    15906    +9     
=======================================
+ Hits        15262    15271    +9     
  Misses        635      635           
Flag Coverage Δ
unit 96.00% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Dec 20, 2023

Codecov Report

Merging #316 (527546c) into main (8d0aaae) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #316   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         614      614           
  Lines       15897    15906    +9     
=======================================
+ Hits        15262    15271    +9     
  Misses        635      635           
Flag Coverage Δ
unit 96.00% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/shared/permissions.py 98.82% <100.00%> (+0.05%) ⬆️
core/commands/flag/interactors/delete_flag.py 100.00% <100.00%> (ø)

Impacted file tree graph

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8d0aaae) 95.62% compared to head (527546c) 95.63%.

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #316     +/-   ##
=======================================
+ Coverage   95.62   95.63   +0.01     
=======================================
  Files        729     729             
  Lines      16406   16416     +10     
=======================================
+ Hits       15688   15698     +10     
  Misses       718     718             
Flag Coverage Δ
unit 96.00% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.00% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JerrySentry JerrySentry merged commit dac762f into main Dec 28, 2023
21 checks passed
@JerrySentry JerrySentry deleted the api_i181_head branch December 28, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants