feat: expand message for gm marketplace customer when customer has previous plan #324
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=====================================
Coverage 95.64 95.64
=====================================
Files 730 730
Lines 16433 16433
=====================================
Hits 15716 15716
Misses 717 717
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 615 615
Lines 15922 15922
=======================================
Hits 15288 15288
Misses 634 634
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #324 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 615 615
Lines 15922 15922
=======================================
Hits 15288 15288
Misses 634 634
Flags with carried forward coverage won't be shown. Click here to find out more.
|
webhook_handlers/views/github.py
Outdated
| extra=dict(username=username), | ||
| extra=dict( | ||
| username=username, | ||
| plan_name=subscription.plan.get("name", None), |
There was a problem hiding this comment.
Should we call this old_plan_name to be more explicit?
There was a problem hiding this comment.
Sounds good! Will do
adrian-codecov
deleted the
150-adjust-ghm-message-when-customer-has-plan
branch
Purpose/Motivation
Closes https://github.com/codecov/internal-issues/issues/150
What does this PR do?
Adds a quick extra params to ghm customers
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.