-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve logging for GHM plan changes #332
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
=====================================
Coverage 95.63 95.63
=====================================
Files 731 731
Lines 16459 16461 +2
=====================================
+ Hits 15740 15742 +2
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov Report
@@ Coverage Diff @@
## main #332 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 616 616
Lines 15948 15950 +2
=======================================
+ Hits 15312 15314 +2
Misses 636 636
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 616 616
Lines 15948 15950 +2
=======================================
+ Hits 15312 15314 +2
Misses 636 636
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Purpose/Motivation
Following up from https://github.com/codecov/internal-issues/issues/150, add some extra fields to our logs if the user has an active subscription. More info about the payload object here.
Adding the following info to logs:
Links to relevant tickets
This closes https://github.com/codecov/internal-issues/issues/151
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.