Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for GHM plan changes #332

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Jan 8, 2024

Purpose/Motivation

Following up from https://github.com/codecov/internal-issues/issues/150, add some extra fields to our logs if the user has an active subscription. More info about the payload object here.

Adding the following info to logs:

  • From plan
  • From no. seats
  • To plan
  • To no. seats

Links to relevant tickets

This closes https://github.com/codecov/internal-issues/issues/151

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7179428) 95.63% compared to head (6ba69b3) 95.63%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #332   +/-   ##
=====================================
  Coverage   95.63   95.63           
=====================================
  Files        731     731           
  Lines      16459   16461    +2     
=====================================
+ Hits       15740   15742    +2     
  Misses       719     719           
Flag Coverage Δ
unit 96.01% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review January 9, 2024 00:05
@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link

Codecov Report

Merging #332 (6ba69b3) into main (7179428) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         616      616           
  Lines       15948    15950    +2     
=======================================
+ Hits        15312    15314    +2     
  Misses        636      636           
Flag Coverage Δ
unit 96.01% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webhook_handlers/views/github.py 98.88% <100.00%> (+<0.01%) ⬆️

Impacted file tree graph

@codecov-qa
Copy link

codecov-qa bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7179428) 96.01% compared to head (6ba69b3) 96.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #332   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         616      616           
  Lines       15948    15950    +2     
=======================================
+ Hits        15312    15314    +2     
  Misses        636      636           
Flag Coverage Δ
unit 96.01% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rohitvinnakota-codecov rohitvinnakota-codecov merged commit 9a207e0 into main Jan 9, 2024
21 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota/151-improve-logging branch January 9, 2024 19:03
Copy link

@barnett-yuxiang barnett-yuxiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants