-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add languages and bundle_analysis_enabled columns to repos #333
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 616 618 +2
Lines 15950 15963 +13
=======================================
+ Hits 15314 15327 +13
Misses 636 636
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
=======================================
Coverage 96.01% 96.01%
=======================================
Files 616 618 +2
Lines 15950 15963 +13
=======================================
+ Hits 15314 15327 +13
Misses 636 636
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #333 +/- ##
=======================================
+ Coverage 95.63 95.64 +0.01
=======================================
Files 731 733 +2
Lines 16461 16493 +32
=======================================
+ Hits 15742 15774 +32
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
What is the feature? Why is this being done?
Add two columns:
languages
stores list of supported languages in a given repo,bundle_analysis_enabled
is true when the user has uploaded bundle reports, ie they are using bundle analysis featureLinks to relevant tickets
codecov/engineering-team#963
codecov/engineering-team#1005
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.