Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add languages and bundle_analysis_enabled columns to repos #333

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

JerrySentry
Copy link
Contributor

@JerrySentry JerrySentry commented Jan 9, 2024

Purpose/Motivation

What is the feature? Why is this being done?

Add two columns: languages stores list of supported languages in a given repo, bundle_analysis_enabled is true when the user has uploaded bundle reports, ie they are using bundle analysis feature

Links to relevant tickets

codecov/engineering-team#963
codecov/engineering-team#1005

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-staging
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a207e0) 96.01% compared to head (1a10f1e) 96.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         616      618    +2     
  Lines       15950    15963   +13     
=======================================
+ Hits        15314    15327   +13     
  Misses        636      636           
Flag Coverage Δ
unit 96.01% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codecov-public-qa bot commented Jan 9, 2024

Codecov Report

Merging #333 (1a10f1e) into main (9a207e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #333   +/-   ##
=======================================
  Coverage   96.01%   96.01%           
=======================================
  Files         616      618    +2     
  Lines       15950    15963   +13     
=======================================
+ Hits        15314    15327   +13     
  Misses        636      636           
Flag Coverage Δ
unit 96.01% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/migrations/0042_repository_languages.py 100.00% <100.00%> (ø)
...rations/0043_repository_bundle_analysis_enabled.py 100.00% <100.00%> (ø)
core/models.py 94.67% <100.00%> (+0.04%) ⬆️

Impacted file tree graph

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9a207e0) 95.63% compared to head (6b998cc) 95.64%.

❗ Current head 6b998cc differs from pull request most recent head 1a10f1e. Consider uploading reports for the commit 1a10f1e to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #333     +/-   ##
=======================================
+ Coverage   95.63   95.64   +0.01     
=======================================
  Files        731     733      +2     
  Lines      16461   16493     +32     
=======================================
+ Hits       15742   15774     +32     
  Misses       719     719             
Flag Coverage Δ
unit 96.01% <100.00%> (+<0.01%) ⬆️
unit-latest-uploader 96.01% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

core/models.py Outdated Show resolved Hide resolved
@JerrySentry JerrySentry merged commit e271b42 into main Jan 9, 2024
18 of 19 checks passed
@JerrySentry JerrySentry deleted the api_963 branch January 9, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants