-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sync providers change #348
Conversation
@@ -6,34 +6,46 @@ | |||
|
|||
import services.self_hosted as self_hosted | |||
from codecov.db import sync_to_async | |||
from codecov_auth.models import Service | |||
from graphql_api.types.enums.enums import LoginProvider | |||
|
|||
config_bindable = ObjectType("Config") | |||
|
|||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff makes it look confusing, its just some refactoring, it's better to compare file side by side
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
=====================================
Coverage 95.70 95.70
=====================================
Files 740 740
Lines 16712 16715 +3
=====================================
+ Hits 15993 15996 +3
Misses 719 719
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
Codecov Report
@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 625 625
Lines 16196 16199 +3
=======================================
+ Hits 15560 15563 +3
Misses 636 636
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #348 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 625 625
Lines 16196 16199 +3
=======================================
+ Hits 15560 15563 +3
Misses 636 636
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
Update sync providers GQL
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.